Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compress] Add range request control option #11975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[compress] Add range request control option #11975

wants to merge 1 commit into from

Conversation

masaori335
Copy link
Contributor

@masaori335 masaori335 commented Jan 20, 2025 •
edited
Loading

Prior to the change, the range-request config controls compress plugin to skip compression if Range request. However, this makes unexpected behavior once the object is cached without Range request.

To fix the case, this removes Range header if client send both of Accept-Encoding and Range header.

@masaori335 masaori335 added the compress compress plugin label Jan 20, 2025
@masaori335 masaori335 added this to the 10.1.0 milestone Jan 20, 2025
@masaori335 masaori335 self-assigned this Jan 20, 2025
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from d24802a to 99b4ac6 Compare January 20, 2025 07:55
@masaori335 masaori335 mentioned this pull request Jan 27, 2025
Open
@bneradt bneradt requested a review from bryancall January 27, 2025 23:09
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from 60b6002 to c911c9b Compare February 20, 2025 05:51
@masaori335 masaori335 changed the title [compress] Fix range-request false [compress] Add range request control option Feb 20, 2025
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from abe61ed to c3859ed Compare February 20, 2025 06:41
@masaori335
Copy link
Contributor Author

Update: add a new option to remove Accept-Encoding header. Now, we can choose Accept-Encoding header or Range header if a client sends both headers.

@masaori335
Copy link
Contributor Author

[approve ci autest 3of4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryancall bryancall Awaiting requested review from bryancall

At least 1 approving review is required to merge this pull request.

Assignees

@masaori335 masaori335

Labels
compress compress plugin
Projects
ATS v10.0.x
Status: No status
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@masaori335